[website] Fix Toggle Button styles in the homepage demos #40744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40744--material-ui.netlify.app/ Bundle size report |
mohamedsaiedd
changed the title
danilo-leal
changed the title
danilo-leal
added
the
website
danilo-leal
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Heya @mohamedsaiedd, thanks for opening the PR!
We can actually fix this problem without adding any z-index treatment. If you delete everything that's being passed through the sx prop in the src/components/showcase/ThemeToggleButton.tsx file, the problem should be solved.
|
Thank you @danilo-leal for the clarification i tried to play with the gray border color which was the main issue for the nonselected elements and it works so fine in the dark and light themes ,if we delete all the CSS properties the design might be totally different.
|
danilo-leal
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the MuiToggleButton for selected button right border overlap issue by adding z-index property as higher layer for "Mui-selected" class and "MuiToggleButton" class lower z-index.
Closes #40727